From 0eac1a66f9c5eac9840d319d791e5d2e974ddebc Mon Sep 17 00:00:00 2001
From: philipp <philipp@hofer.link>
Date: Thu, 16 May 2024 22:35:26 +0200
Subject: [PATCH] better layout

---
 src/tera/mod.rs             |  10 ++-
 src/tera/planned.rs         |   6 --
 templates/index.html.tera   | 125 ++++++++++++++++++++----------------
 templates/planned.html.tera |  21 ------
 4 files changed, 77 insertions(+), 85 deletions(-)

diff --git a/src/tera/mod.rs b/src/tera/mod.rs
index c47c7f1..c38206c 100644
--- a/src/tera/mod.rs
+++ b/src/tera/mod.rs
@@ -21,9 +21,10 @@ use sqlx::SqlitePool;
 use tera::Context;
 
 use crate::model::{
+    logbook::Logbook,
     notification::Notification,
     role::Role,
-    user::{User, UserWithDetails},
+    user::{User, UserWithDetails, SCHECKBUCH},
 };
 
 pub(crate) mod admin;
@@ -52,8 +53,15 @@ async fn index(db: &State<SqlitePool>, user: User, flash: Option<FlashMessage<'_
         context.insert("flash", &msg.into_inner());
     }
 
+    if user.has_role(db, "scheckbuch").await {
+        let last_trips = Logbook::completed_with_user(db, &user).await;
+        context.insert("last_trips", &last_trips);
+    }
+
     context.insert("notifications", &Notification::for_user(db, &user).await);
     context.insert("loggedin_user", &UserWithDetails::from_user(user, db).await);
+    context.insert("costs_scheckbuch", &SCHECKBUCH);
+
     Template::render("index", context.into_json())
 }
 
diff --git a/src/tera/planned.rs b/src/tera/planned.rs
index 5e5c7e3..924a739 100644
--- a/src/tera/planned.rs
+++ b/src/tera/planned.rs
@@ -32,11 +32,6 @@ async fn index(
         context.insert("trip_types", &triptypes);
     }
 
-    if user.has_role(db, "scheckbuch").await {
-        let last_trips = Logbook::completed_with_user(db, &user).await;
-        context.insert("last_trips", &last_trips);
-    }
-
     let days = user.get_days(db).await;
 
     if let Some(msg) = flash {
@@ -46,7 +41,6 @@ async fn index(
     context.insert("fee", &user.fee(db).await);
     context.insert("loggedin_user", &UserWithDetails::from_user(user, db).await);
     context.insert("days", &days);
-    context.insert("costs_scheckbuch", &SCHECKBUCH);
     Template::render("planned", context.into_json())
 }
 
diff --git a/templates/index.html.tera b/templates/index.html.tera
index f863cf8..de691d6 100644
--- a/templates/index.html.tera
+++ b/templates/index.html.tera
@@ -1,12 +1,9 @@
 {% import "includes/macros" as macros %}
+{% import "includes/forms/log" as log %}
 {% extends "base" %}
 {% block content %}
     <div class="max-w-screen-lg w-full">
-        <h1 class="h1">
-            Ruder
-            <wbr />
-            assistent
-        </h1>
+        <h1 class="h1">Ruder&shy;assistent</h1>
         <div class="grid gap-3 my-5">
             <div class="m-auto">
                 <a href="/planned"
@@ -15,55 +12,57 @@
                     <span class="text-xl px-3">Geplante Ausfahrten</span>
                 </a>
             </div>
-            <div id="notification"
-                 class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
-                 role="alert">
-                <h2 class="h2">Nachrichten</h2>
-                {% if loggedin_user.amount_unread_notifications > 10 %}
-                    <div class="text-primary-950 dark:text-white bg-gray-200 dark:bg-primary-950 bg-opacity-80 text-center pb-3 px-3">
-                        Du hast viele ungelesene Benachrichtigungen. Um deine Oberfläche übersichtlich zu halten und wichtige Updates nicht zu verpassen, nimm dir bitte einen Moment Zeit sie zu überprüfen und als gelesen zu markieren (&#10003;).
-                    </div>
-                {% endif %}
-                <div class="divide-y">
-                    {% for notification in notifications %}
-                        {% if not notification.read_at %}
-                            <div class="relative flex justify-between items-center p-3">
-                                <div class="grow me-4">
-                                    <small class="uppercase text-gray-600 dark:text-gray-100">
-                                        <strong>{{ notification.category }}</strong> &bullet; {{ notification.created_at | date(format="%d.%m.%Y %H:%M",) }}
-                                    </small>
-                                    <div class="mt-1">{{ notification.message | safe }}</div>
-                                </div>
-                                <div>
-                                    {% if not notification.read_at %}
-                                        <a href="/notification/{{ notification.id }}/read" class="inline-block">
-                                            <button class="btn btn-primary" type="button">
-                                                &#10003;
-                                                <span class="sr-only">Notification gelesen</span>
-                                            </button>
-                                        </a>
-                                    {% endif %}
-                                </div>
-                            </div>
-                        {% endif %}
-                    {% endfor %}
-                </div>
-                <details class="py-3 border-t rounded-b-md">
-                    <summary class="px-3 cursor-pointer">Vergangene Nachrichten (14 Tage)</summary>
-                    <div class="divide-y text-sm">
+            {% if notifications %}
+                <div id="notification"
+                     class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
+                     role="alert">
+                    <h2 class="h2">Nachrichten</h2>
+                    {% if loggedin_user.amount_unread_notifications > 10 %}
+                        <div class="text-primary-950 dark:text-white bg-gray-200 dark:bg-primary-950 bg-opacity-80 text-center pb-3 px-3">
+                            Du hast viele ungelesene Benachrichtigungen. Um deine Oberfläche übersichtlich zu halten und wichtige Updates nicht zu verpassen, nimm dir bitte einen Moment Zeit sie zu überprüfen und als gelesen zu markieren (&#10003;).
+                        </div>
+                    {% endif %}
+                    <div class="divide-y">
                         {% for notification in notifications %}
-                            {% if notification.read_at %}
-                                <div class="p-3 relative">
-                                    <small class="uppercase text-gray-600 dark:text-gray-100">
-                                        <strong>{{ notification.category }}</strong> &bullet; {{ notification.created_at | date(format="%d.%m.%Y %H:%M") }}
-                                    </small>
-                                    <div class="mt-1">{{ notification.message | safe }}</div>
+                            {% if not notification.read_at %}
+                                <div class="relative flex justify-between items-center p-3">
+                                    <div class="grow me-4">
+                                        <small class="uppercase text-gray-600 dark:text-gray-100">
+                                            <strong>{{ notification.category }}</strong> &bullet; {{ notification.created_at | date(format="%d.%m.%Y %H:%M",) }}
+                                        </small>
+                                        <div class="mt-1">{{ notification.message | safe }}</div>
+                                    </div>
+                                    <div>
+                                        {% if not notification.read_at %}
+                                            <a href="/notification/{{ notification.id }}/read" class="inline-block">
+                                                <button class="btn btn-primary" type="button">
+                                                    &#10003;
+                                                    <span class="sr-only">Notification gelesen</span>
+                                                </button>
+                                            </a>
+                                        {% endif %}
+                                    </div>
                                 </div>
                             {% endif %}
                         {% endfor %}
                     </div>
-                </details>
-            </div>
+                    <details class="py-3 border-t rounded-b-md">
+                        <summary class="px-3 cursor-pointer">Vergangene Nachrichten (14 Tage)</summary>
+                        <div class="divide-y text-sm">
+                            {% for notification in notifications %}
+                                {% if notification.read_at %}
+                                    <div class="p-3 relative">
+                                        <small class="uppercase text-gray-600 dark:text-gray-100">
+                                            <strong>{{ notification.category }}</strong> &bullet; {{ notification.created_at | date(format="%d.%m.%Y %H:%M") }}
+                                        </small>
+                                        <div class="mt-1">{{ notification.message | safe }}</div>
+                                    </div>
+                                {% endif %}
+                            {% endfor %}
+                        </div>
+                    </details>
+                </div>
+            {% endif %}
             {% if "Donau Linz" in loggedin_user.roles and "Unterstützend" not in loggedin_user.roles and "Förderndes Mitglied" not in loggedin_user.roles %}
                 <div class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
                      role="alert">
@@ -98,14 +97,26 @@
                 </div>
             {% endif %}
             {% if "scheckbuch" in loggedin_user.roles %}
-                <div class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
-                     role="alert">
-                    <h2 class="h2">Scheckbuch</h2>
-                    <ul class="list-none ms-2 divide-y divide-gray-200 dark:divide-primary-600">
-                        <li class="py-1">
-                            <a href="/planned" class="block w-100 py-2 hover:text-primary-600">Geplante Ausfahrten</a>
-                        </li>
-                    </ul>
+                <div class="grid gap-3 mb-4">
+                    <div class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
+                         role="alert">
+                        <h2 class="h2">Scheckbuch</h2>
+                        {% if "paid" not in loggedin_user.roles %}
+                            <div class="p-3 dark:text-white bg-white dark:bg-primary-900">
+                                Bitte nimm zur nächsten Ausfahrt die {{ costs_scheckbuch / 100 }}&nbsp;€ für das Scheckbuch mit. Falls du das bereits gemacht hast, gibt uns bitte kurz Bescheid, dass dies noch nicht eingetragen wurde.
+                            </div>
+                        {% endif %}
+                        <div class="text-sm p-3 bg-gray-200 bg-opacity-80 dark:bg-primary-950 dark:text-white text-primary-950">
+                            <h3>Du hast bisher an {{ last_trips | length }} deiner 5 Scheckbuch-Ausfahrten teilgenommen.</h3>
+                            {% if last_trips %}
+                                <ol class="mt-3">
+                                    {% for last_trip in last_trips %}
+                                        <li>{{ log::show_old(log=last_trip, state="completed", only_ones=false, index=loop.index) }}</li>
+                                    {% endfor %}
+                                </ol>
+                            {% endif %}
+                        </div>
+                    </div>
                 </div>
             {% endif %}
             {% if "schnupper-betreuer" in loggedin_user.roles %}
diff --git a/templates/planned.html.tera b/templates/planned.html.tera
index 1cc6cce..380713c 100644
--- a/templates/planned.html.tera
+++ b/templates/planned.html.tera
@@ -3,27 +3,6 @@
 {% extends "base" %}
 {% block content %}
     <div class="max-w-screen-xl w-full grid sm:grid-cols-2 lg:grid-cols-3 gap-4">
-        {% if "scheckbuch" in loggedin_user.roles %}
-            <div class="grid gap-3 sm:col-span-2 lg:col-span-3">
-                <div class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
-                     role="alert">
-                    <h2 class="h2">Scheckbuch</h2>
-		    	{% if "paid" not in loggedin_user.roles %}
-                        <div class="bg-gray-300 text-center text-black">
-				Bitte nimm zur nächsten Ausfahrt die {{ costs_scheckbuch / 100 }}&nbsp;€ für das Scheckbuch mit. Falls du das bereits gemacht hast, gibt uns bitte kurz Bescheid, dass dies noch nicht eingetragen wurde.
-				</div>
-			{% endif %}
-                    <div class="text-sm p-3">
-                        <h3>Du hast bisher {{ last_trips | length }} deiner 5 Scheckbuch-Ausfahrten gemacht:</h3>
-                        <ol>
-                            {% for last_trip in last_trips %}
-                                <li>{{ log::show_old(log=last_trip, state="completed", only_ones=false, index=loop.index) }}</li>
-                            {% endfor %}
-                        </ol>
-                    </div>
-                </div>
-            </div>
-        {% endif %}
         {% if "paid" not in loggedin_user.roles and "Donau Linz" in loggedin_user.roles %}
             <div class="grid gap-3 sm:col-span-2 lg:col-span-3">
                 <div class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"