From 55b259061bbffe1cd18f18cf1b8b157dca267547 Mon Sep 17 00:00:00 2001
From: philipp <philipp@hofer.link>
Date: Wed, 17 Apr 2024 13:04:03 +0200
Subject: [PATCH 1/2] don't show steer button when there are no coxes planned
 for this event; Fixes #357

---
 templates/admin/mail.html.tera | 10 +++++-----
 templates/base.html.tera       | 14 +++++++++++---
 templates/planned.html.tera    | 12 +++++-------
 3 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/templates/admin/mail.html.tera b/templates/admin/mail.html.tera
index 8f54cd1..6c97d4c 100644
--- a/templates/admin/mail.html.tera
+++ b/templates/admin/mail.html.tera
@@ -8,16 +8,16 @@
             <div class="bg-white dark:bg-primary-900 text-black dark:text-white rounded-md block shadow mt-5"
                  role="alert">
                 <h2 class="h2">Mail versenden</h2>
-                <form action="/admin/mail" method="post" enctype="multipart/form-data" class="grid gap-3 p-3">
+                <form action="/admin/mail"
+                      method="post"
+                      enctype="multipart/form-data"
+                      class="grid gap-3 p-3">
                     {{ macros::select(label="Gruppe", data=roles, name="role_id") }}
                     {{ macros::input(label="Betreff", name="subject", type="text", required=true) }}
                     <div class="">
-                        <label for="content" class=" text-sm text-gray-600 dark:text-white ">
-                            Inhalt
-                        </label>
+                        <label for="content" class=" text-sm text-gray-600 dark:text-white ">Inhalt</label>
                         <textarea id="content" name="body" rows="4" cols="50" class="input rounded-md"></textarea>
                     </div>
-                    
                     <input type="file" name="files" multiple />
                     <input type="submit" class="btn btn-primary" value="Abschicken" />
                 </form>
diff --git a/templates/base.html.tera b/templates/base.html.tera
index 19b468d..c01990b 100644
--- a/templates/base.html.tera
+++ b/templates/base.html.tera
@@ -6,9 +6,17 @@
               content="width=device-width, initial-scale=1, shrink-to-fit=no">
         <link rel="manifest" href="public/manifest.json" />
         <link rel="stylesheet" href="/public/main.css" />
-        <link rel="apple-touch-icon" sizes="180x180" href="/public/images/apple-touch-icon.png">
-        <link rel="icon" type="image/png" sizes="32x32" href="/public/images/favicon-32x32.png">
-        <link rel="icon" type="image/png" sizes="16x16" href="/public/images/favicon-16x16.png">
+        <link rel="apple-touch-icon"
+              sizes="180x180"
+              href="/public/images/apple-touch-icon.png">
+        <link rel="icon"
+              type="image/png"
+              sizes="32x32"
+              href="/public/images/favicon-32x32.png">
+        <link rel="icon"
+              type="image/png"
+              sizes="16x16"
+              href="/public/images/favicon-16x16.png">
         <link rel="manifest" href="/public/images/site.webmanifest">
         <meta name="msapplication-TileColor" content="#da532c">
         <meta name="theme-color" content="#ffffff">
diff --git a/templates/planned.html.tera b/templates/planned.html.tera
index d5ef0f1..638b32f 100644
--- a/templates/planned.html.tera
+++ b/templates/planned.html.tera
@@ -133,12 +133,10 @@
                                                     <a href="/planned/remove/{{ planned_event.trip_details_id }}"
                                                        class="btn btn-attention btn-fw">Abmelden</a>
                                                 {% endif %}
-                                                {% if planned_event.max_people > planned_event.rower | length %}
-                                                    {% if cur_user_participates == false %}
-                                                        <a href="/planned/join/{{ planned_event.trip_details_id }}"
-                                                           class="btn btn-primary btn-fw"
-                                                           {% if planned_event.trip_type %}onclick="return confirm('{{ planned_event.trip_type.question }}');"{% endif %}>Mitrudern</a>
-                                                    {% endif %}
+                                                {% if planned_event.max_people > planned_event.rower | length and cur_user_participates == false %}
+                                                    <a href="/planned/join/{{ planned_event.trip_details_id }}"
+                                                       class="btn btn-primary btn-fw"
+                                                       {% if planned_event.trip_type %}onclick="return confirm('{{ planned_event.trip_type.question }}');"{% endif %}>Mitrudern</a>
                                                 {% endif %}
                                                 {# --- END Row Buttons --- #}
                                                 {# --- START Cox Buttons --- #}
@@ -155,7 +153,7 @@
                                                             {% include "includes/cox-icon" %}
                                                             Abmelden
                                                         </a>
-                                                    {% else %}
+                                                    {% elif planned_event.planned_amount_cox > 0 %}
                                                         <a href="/cox/join/{{ planned_event.id }}"
                                                            class="block btn {% if amount_cox_missing > 0 %} btn-dark {% else %} btn-gray {% endif %} btn-fw"
                                                            {% if planned_event.trip_type %}onclick="return confirm('{{ planned_event.trip_type.question }}');"{% endif %}>

From 858ae28eb3b3080886b3a34cd526c077de4cba0e Mon Sep 17 00:00:00 2001
From: philipp <philipp@hofer.link>
Date: Wed, 17 Apr 2024 13:18:35 +0200
Subject: [PATCH 2/2] allow deletion of boat

---
 migration.sql          |  3 ++-
 src/model/boat.rs      | 18 +++++++++++-------
 src/tera/admin/boat.rs |  5 ++++-
 staging-diff.sql       |  1 +
 4 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/migration.sql b/migration.sql
index 675c976..f19d5f8 100644
--- a/migration.sql
+++ b/migration.sql
@@ -101,7 +101,8 @@ CREATE TABLE IF NOT EXISTS "boat" (
 	"default_shipmaster_only_steering" boolean default false not null,
 	"default_destination" text,
 	"skull" boolean default true NOT NULL, -- false => riemen
-	"external" boolean default false NOT NULL -- false => owned by different club
+	"external" boolean default false NOT NULL, -- false => owned by different club
+	"deleted" boolean NOT NULL DEFAULT FALSE
 );
 
 CREATE TABLE IF NOT EXISTS "logbook_type" (
diff --git a/src/model/boat.rs b/src/model/boat.rs
index f110b19..05a2e1c 100644
--- a/src/model/boat.rs
+++ b/src/model/boat.rs
@@ -26,6 +26,7 @@ pub struct Boat {
     skull: bool,
     #[serde(default = "bool::default")]
     external: bool,
+    pub deleted: bool,
 }
 
 #[derive(Serialize, Deserialize, Debug)]
@@ -188,8 +189,9 @@ AND date('now') BETWEEN start_date AND end_date;",
         let boats = sqlx::query_as!(
             Boat,
             "
-SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external 
+SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external, deleted 
 FROM boat 
+WHERE deleted=false
 ORDER BY amount_seats DESC
         "
         )
@@ -215,12 +217,14 @@ SELECT
     b.default_shipmaster_only_steering, 
     b.default_destination, 
     b.skull, 
-    b.external
+    b.external,
+    b.deleted
 FROM 
     boat AS b
 WHERE 
     b.external = false 
     AND b.location_id = (SELECT id FROM location WHERE name = 'Linz')
+    AND b.deleted = false
 ORDER BY 
     b.name DESC;
         "
@@ -240,7 +244,7 @@ ORDER BY
             sqlx::query_as!(
             Boat,
             "
-SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external 
+SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external, deleted 
 FROM boat 
 WHERE owner is null or owner = ?
 ORDER BY amount_seats DESC
@@ -254,7 +258,7 @@ ORDER BY amount_seats DESC
             sqlx::query_as!(
             Boat,
             "
-SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external 
+SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external, deleted 
 FROM boat 
 WHERE owner = ? OR (owner is null and amount_seats = 1)
 ORDER BY amount_seats DESC
@@ -272,7 +276,7 @@ ORDER BY amount_seats DESC
                 .unwrap();
             let boats_in_ottensheim = sqlx::query_as!(
             Boat,
-            "SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external 
+            "SELECT id, name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external, deleted 
 FROM boat 
 WHERE owner is null and location_id = ? 
 ORDER BY amount_seats DESC
@@ -291,7 +295,7 @@ ORDER BY amount_seats DESC
         let boats = sqlx::query_as!(
             Boat,
             "
-SELECT boat.id, boat.name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external 
+SELECT boat.id, boat.name, amount_seats, location_id, owner, year_built, boatbuilder, default_shipmaster_only_steering, default_destination, skull, external, deleted
 FROM boat 
 INNER JOIN location ON boat.location_id = location.id
 WHERE location.name=?
@@ -354,7 +358,7 @@ ORDER BY amount_seats DESC
     }
 
     pub async fn delete(&self, db: &SqlitePool) {
-        sqlx::query!("DELETE FROM boat WHERE id=?", self.id)
+        sqlx::query!("UPDATE boat SET deleted=1 WHERE id=?", self.id)
             .execute(db)
             .await
             .unwrap(); //Okay, because we can only create a Boat of a valid id
diff --git a/src/tera/admin/boat.rs b/src/tera/admin/boat.rs
index d8776f6..e23d2e4 100644
--- a/src/tera/admin/boat.rs
+++ b/src/tera/admin/boat.rs
@@ -1,6 +1,7 @@
 use crate::model::{
     boat::{Boat, BoatToAdd, BoatToUpdate},
     location::Location,
+    log::Log,
     user::{AdminUser, User, UserWithRoles},
 };
 use rocket::{
@@ -39,8 +40,10 @@ async fn index(
 }
 
 #[get("/boat/<boat>/delete")]
-async fn delete(db: &State<SqlitePool>, _admin: AdminUser, boat: i32) -> Flash<Redirect> {
+async fn delete(db: &State<SqlitePool>, admin: AdminUser, boat: i32) -> Flash<Redirect> {
     let boat = Boat::find_by_id(db, boat).await;
+    Log::create(db, format!("{} deleted boat: {boat:?}", admin.user.name)).await;
+
     match boat {
         Some(boat) => {
             boat.delete(db).await;
diff --git a/staging-diff.sql b/staging-diff.sql
index 05203dd..6fb21fc 100644
--- a/staging-diff.sql
+++ b/staging-diff.sql
@@ -1,3 +1,4 @@
+-- test user
 INSERT INTO user(name) VALUES('Marie');
 INSERT INTO "user_role" (user_id, role_id) VALUES((SELECT id from user where name = 'Marie'),(SELECT id FROM role where name = 'Donau Linz'));
 INSERT INTO user(name) VALUES('Philipp');