user-role-cluster (#761)

Reviewed-on: #761

src/tera/admin/user.rs

@@ -200,7 +200,8 @@ async fn fees_paid(
             )
             .await;
             user.add_role(db, &Role::find_by_name(db, "paid").await.unwrap())
-                .await;
+                .await
+                .expect("paid role has no group");
         }
     }
 
@@ -305,9 +306,10 @@ async fn update(
         );
     };
 
-    user.update(db, data.into_inner()).await;
-
-    Flash::success(Redirect::to("/admin/user"), "Successfully updated user")
+    match user.update(db, data.into_inner()).await {
+        Ok(_) => Flash::success(Redirect::to("/admin/user"), "Successfully updated user"),
+        Err(e) => Flash::error(Redirect::to("/admin/user"), e),
+    }
 }
 
 #[get("/user/<user>/membership")]
@@ -394,7 +396,9 @@ async fn create_scheckbuch(
 
     // 4. Add 'scheckbuch' role
     let scheckbuch = Role::find_by_name(db, "scheckbuch").await.unwrap();
-    user.add_role(db, &scheckbuch).await;
+    user.add_role(db, &scheckbuch)
+        .await
+        .expect("new user has no roles yet");
 
     // 4. Send welcome mail (+ notification)
     user.send_welcome_email(db, &config.smtp_pw).await.unwrap();
@@ -434,10 +438,14 @@ async fn schnupper_to_scheckbuch(
     user.remove_role(db, &paid).await;
 
     let scheckbuch = Role::find_by_name(db, "scheckbuch").await.unwrap();
-    user.add_role(db, &scheckbuch).await;
+    user.add_role(db, &scheckbuch)
+        .await
+        .expect("just removed 'schnupperant' thus can't have a role with that group");
 
     if let Some(no_einschreibgebuehr) = Role::find_by_name(db, "no-einschreibgebuehr").await {
-        user.add_role(db, &no_einschreibgebuehr).await;
+        user.add_role(db, &no_einschreibgebuehr)
+            .await
+            .expect("role doesn't have a group");
     }
 
     user.send_welcome_email(db, &config.smtp_pw).await.unwrap();