allow final usertype changes; Fixes #954

src/model/user/schnupperant.rs

@@ -98,6 +98,12 @@ impl SchnupperantUser {
         self.user.remove_role(db, changed_by, &schnupperant).await?;
         self.user.add_role(db, changed_by, &scheckbook).await?;
 
+        if let Some(no_einschreibgebuehr) = Role::find_by_name(db, "no-einschreibgebuehr").await {
+            self.add_role(db, &changed_by, &no_einschreibgebuehr)
+                .await
+                .expect("role doesn't have a group");
+        }
+
         let scheckbook = ScheckbuchUser::new(db, &self.user).await.unwrap();
         scheckbook.send_welcome_mail_to_user(db, smtp_pw).await?;
 
@@ -115,6 +121,38 @@ impl SchnupperantUser {
         Ok(())
     }
 
+    pub(crate) async fn move_to_schnupperinterest(
+        self,
+        db: &SqlitePool,
+        changed_by: &ManageUserUser,
+    ) -> Result<(), String> {
+        let schnupperinterest = Role::find_by_name(db, "schnupper-interessierte")
+            .await
+            .unwrap();
+        let schnupperant = Role::find_by_name(db, "schnupperant").await.unwrap();
+        self.user.remove_role(db, changed_by, &schnupperant).await?;
+        self.user
+            .add_role(db, changed_by, &schnupperinterest)
+            .await?;
+
+        if let Some(role) = Role::find_by_name(db, "schnupper-betreuer").await {
+            Notification::create_for_role(
+                db,
+                &role,
+                &format!(
+                    "Lieber Schnupperbetreuer, {} hat sich vom Schnupperkurs abgemeldet.",
+                    self.name
+                ),
+                "Schnupperkurs Abmeldung",
+                None,
+                None,
+            )
+            .await;
+        }
+
+        Ok(())
+    }
+
     pub(crate) async fn convert_to_unterstuetzend_user(
         self,
         db: &SqlitePool,
@@ -143,6 +181,11 @@ impl SchnupperantUser {
         let scheckbook = Role::find_by_name(db, "schnupperant").await.unwrap();
         self.user.remove_role(db, changed_by, &scheckbook).await?;
         self.user.add_role(db, changed_by, &unterstuetzend).await?;
+        if let Some(no_einschreibgebuehr) = Role::find_by_name(db, "no-einschreibgebuehr").await {
+            self.add_role(db, &changed_by, &no_einschreibgebuehr)
+                .await
+                .expect("role doesn't have a group");
+        }
 
         let unterstuetzend = UnterstuetzendUser::new(db, &self.user).await.unwrap();
         unterstuetzend
@@ -195,6 +238,11 @@ impl SchnupperantUser {
         let scheckbook = Role::find_by_name(db, "schnupperant").await.unwrap();
         self.user.remove_role(db, changed_by, &scheckbook).await?;
         self.user.add_role(db, changed_by, &unterstuetzend).await?;
+        if let Some(no_einschreibgebuehr) = Role::find_by_name(db, "no-einschreibgebuehr").await {
+            self.add_role(db, &changed_by, &no_einschreibgebuehr)
+                .await
+                .expect("role doesn't have a group");
+        }
 
         let foerdernd = FoerderndUser::new(db, &self.user).await.unwrap();
         foerdernd.send_welcome_mail_to_user(db, smtp_pw).await?;
@@ -218,14 +266,9 @@ impl SchnupperantUser {
     }
 
     // TODO: make private
-    pub(crate) async fn notify(
-        &self,
-        db: &SqlitePool,
-        mail: &str,
-        smtp_pw: &str,
-    ) -> Result<(), String> {
+    pub(crate) async fn notify(&self, db: &SqlitePool, smtp_pw: &str) -> Result<(), String> {
         self.notify_coxes_about_new_scheckbuch(db).await;
-        self.send_welcome_mail_to_user(db, mail, smtp_pw).await?;
+        self.send_welcome_mail_to_user(db, smtp_pw).await?;
 
         Ok(())
     }
@@ -233,13 +276,17 @@ impl SchnupperantUser {
     async fn send_welcome_mail_to_user(
         &self,
         db: &SqlitePool,
-        mail: &str,
         smtp_pw: &str,
     ) -> Result<(), String> {
+        let Some(mail) = &self.mail else {
+            return Err(format!(
+                "Couldn't send mail, because user {self} has no mail"
+            ));
+        };
         Mail::send_single(
             db,
-            mail,
-            "ASKÖ Ruderverein Donau Linz | Dein Scheckbuch wartet auf Dich",
+            &mail,
+            "ASKÖ Ruderverein Donau Linz | Anmeldung Schnupperkurs",
             format!(
 "Hallo {0},